Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two new repository labels #280

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add two new repository labels #280

merged 1 commit into from
Oct 27, 2023

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request adds the ansible and packer labels to the crazy-max/ghaction-github-labeler configuration.

Note

I am not bumping the version because this pull request is a minor change to the GitHub Actions configuration.

💭 Motivation and context

Since this project structure contains a Packer configuration that itself contains an Ansible configuration we should have labels available to indicate what is being changed.

🧪 Testing

Automated tests pass. The Action run shows these two labels would be created.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation github-actions Pull requests that update GitHub Actions code labels Oct 24, 2023
@mcdonnnj mcdonnnj self-assigned this Oct 24, 2023
dav3r
dav3r approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️ 🏷️

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Oct 27, 2023
@mcdonnnj
Add two new repository labels
c6249c3 
Add `ansible` and `packer` labels to the
crazy-max/ghaction-github-labeler configuration.
@mcdonnnj mcdonnnj added this pull request to the merge queue Oct 27, 2023
Merged via the queue into develop with commit 34cbea7 Oct 27, 2023
11 checks passed
@mcdonnnj mcdonnnj deleted the improvement/add_some_labels branch October 27, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r